Explicitly require active_support/core_ext/array/conversions#2144
Merged
dblock merged 1 commit intoruby-grape:masterfrom Dec 29, 2020
Merged
Explicitly require active_support/core_ext/array/conversions#2144dblock merged 1 commit intoruby-grape:masterfrom
dblock merged 1 commit intoruby-grape:masterfrom
Conversation
…Array#to_xml method
anakinj
force-pushed
the
activesupport61-fix
branch
from
80bbddc to
e65bdc1
Compare
Generated by 🚫 danger |
Member
|
👍 |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grape is not explicitly loading the activesupport parts that are required for Array#to_xml. Because of this the Array serialization to XML breaks when activesupport 6.1 is taken into use.
The commit that deletes what previously was requiring the parts that Grape relies on is this rails/rails@12959de#diff-f805b1a36e26831e5eee78fb55549de44fb842f78443b178d5d5438105152017