Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Ruby 2.7 + changelog fixes #1951

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

nbulaj
Copy link
Contributor

@nbulaj nbulaj commented Dec 31, 2019

As from the title: small fix for kwargs in Grape::Exceptions::Validation class and typo fix in changelog.

@grape-bot
Copy link

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Jan 2, 2020

Is this something that fixes a bug? I mean is there a test that can be written that fails without this change?

@nbulaj
Copy link
Contributor Author

nbulaj commented Jan 2, 2020

No-no, it's not a bugfix :) It's one more fix for Ruby 2.7 / 3.0 kwargs deprecatiob messages that eas somehow lost in #1949 . Without it you'll just see a warning in the stdout. And a typo fix in the changelog. So no additional specs required, just regression that already exist

@dblock dblock merged commit d9cf755 into ruby-grape:master Jan 2, 2020
@anatol
Copy link

anatol commented Jan 8, 2020

We are looking at ruby2.7 issues in gitlab and one we found is https://gitlab.com/gitlab-org/gitlab/issues/194348 Could it be related to the fix above? Or you think the issue is somewhere else?

@dblock
Copy link
Member

dblock commented Jan 8, 2020

Maybe. I would check against HEAD, but also note #1957.

@nbulaj nbulaj deleted the small-ruby-2.7-fixes branch January 9, 2020 11:50
@nbulaj
Copy link
Contributor Author

nbulaj commented Jan 9, 2020

@anatol I checked GitLab issue and don't sure I understood the source of the issue. I mean I can't find in the logs who exactly produced an error you faced (GitLab internals? rack oauth2? Grape?).

This PR and #1949 add double-splat operator in places where Grape uses kwargs in method definition. It could be a source of the issue, but first it would be great to find the line of the code which produces it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants