Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 2.7 #1949

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

nbulaj
Copy link
Contributor

@nbulaj nbulaj commented Dec 27, 2019

Add support for Ruby 2.7 both in Travis and in Grape itself


Ruby 2.7.0 was released December 25, 2019, and has some noisy deprecation messages about wrong usage of keyword arguments.

Grape gem already correctly uses double-splat operator in some places, but not all over the code-base. That must be fixed.

So, what's done here:

  • Add Ruby 2.7 to Travis matrix, use 2.6.x for Gemfile and rails 5 as it's already done for previous versions.
  • Fix method signatures and calls that produce deprecation messages for kwargs used.

To see a ton of deprecation messages you can just install Ruby 2.7, checkout current master branch and run test suite. There are still some messages not related to the gem itself that comes from mustermann, multi_json and a few other gems that must be fixed themselves.

* Add Ruby 2.7 to Travis
* Fix calls with deprecation messages for kwargs
@dblock dblock merged commit cf57d25 into ruby-grape:master Dec 28, 2019
@nbulaj nbulaj deleted the add-support-for-ruby-2.7 branch December 28, 2019 15:09
@anatol
Copy link

anatol commented Jan 8, 2020

Is there any plan to release a gem version that supports ruby2.7 (i.e. with the ruby27 fixes above)?

@dblock
Copy link
Member

dblock commented Jan 8, 2020

Is there any plan to release a gem version that supports ruby2.7 (i.e. with the ruby27 fixes above)?

Yes, but at the very least we need to check #1957. Maybe you can help?

@dblock
Copy link
Member

dblock commented Jan 8, 2020

#1958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants