-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect deprecations #1357
Conversation
9877ddc
to
96eade9
Compare
@@ -56,6 +57,15 @@ def route_path | |||
pattern.path | |||
end | |||
|
|||
def hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we really just trying to make grape-swagger happy here? The whole hidden
thing is not a Grape feature, just happens to be an option that grape-swagger "extends". Maybe it's better to expose options
instead and let grape-swagger deal with it?
96eade9
to
9edb8f9
Compare
@dblock Thanks for your opinion. I've just tried to reflect it to my changes. |
I am happy with this as is, squashed and CHANGELOGed. |
I also think the code needs comments of what |
Expose Route#options
9edb8f9
to
52f60a4
Compare
@dblock Could you review this updates? I also squashed :) |
Looks good to me, feel free to merge on green if I don't get to it. |
ref #1344