Deprecated route_xxx methods for route_params and route_? declared.

[dblock]

I've PRed ruby-grape/grape-swagger#368, but it has two problems, access to route_params and route_hidden in a dummy API declared as GET '/foobar', hidden: true.

The route_xxx deprecated code reaches into @options, which isn't @settings, and that is no longer exposed. So .params is not the same thing as the old route_params. What should we do about this one?

[dblock]

cc: @namusyaka, maybe you have a suggestion?

[namusyaka]

@dblock Hmm, I think the route_xxx can explore the @options and @settings in a cascading style.
I'm going to investigate the problem in a few days.

[dblock]

If you have time @namusyaka, the simplest thing to look at is https://github.com/dblock/grape-swagger/tree/fix-deprecations, try to fix the remaining deprecations. I think the simplest would be to just expose options, but maybe the specs are wrong and it's not the right thing to do.

[dblock]

For now I am monkey-patching the deprecation to avoid too many warnings being spewed.

module Grape
  class Router
    class Route
      private

      # TODO: remove when https://github.com/ruby-grape/grape-swagger/pull/368 and https://github.com/newrelic/rpm/pull/235 are finished
      def warn_route_methods(name, location, expected = nil)
      end
    end
  end
end

[dblock]

Closing via #1357.

[dblock]

newrelic/newrelic-ruby-agent#282