Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Grape 0.16.2 and fix route_xxx deprecations. #375

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 11, 2016

Will be released as 0.11.0 to support Grape 0.16.x.

@dblock dblock changed the title Require Grape 0.16.2 and fix route_xxx deprecations. [WIP] Require Grape 0.16.2 and fix route_xxx deprecations. Apr 11, 2016
@dblock dblock changed the title [WIP] Require Grape 0.16.2 and fix route_xxx deprecations. Require Grape 0.16.2 and fix route_xxx deprecations. Apr 11, 2016
@dblock
Copy link
Member Author

dblock commented Apr 11, 2016

@LeFnord Can you please look over this and merge? I can cut a 0.11.0 release out of this unless you beat me to it.

@LeFnord
Copy link
Member

LeFnord commented Apr 11, 2016

👍 … send you a PM

@LeFnord
Copy link
Member

LeFnord commented Apr 12, 2016

cherry-picked it, cause of merge conflicts … GH is curious since some weeks

@LeFnord LeFnord closed this Apr 12, 2016
@ShallmentMo
Copy link

I have a problem now. If I use grape-swagger = 0.20, the warning come out. If I use grape-swagger = 0.11.0 , I have to use grape-entity < 0.5.0. I'm using grape-entity = 0.5.1 now. If I change grape-entity, I might have to change so much code. Please give me some advice.

@dblock
Copy link
Member Author

dblock commented Apr 15, 2016

It sounds like we really want #314 to be fixed, aka grape-swagger to work with a newer version of grape-entity. I think 0.20 is the way to go, it should probably be locked above grape 0.16.2 and deprecations fixed. Thoughts @LeFnord ?

@LeFnord
Copy link
Member

LeFnord commented Apr 15, 2016

yeap, will fix 0.20.0 to grape < 0.15.0 and grape-entity 0.4.8, as in the announcement described 😉
see: #364

@LeFnord
Copy link
Member

LeFnord commented Apr 15, 2016

did it: #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants