Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grape: route_xxx methods have been deprecated #364

Closed
ngonzalez opened this issue Apr 1, 2016 · 7 comments
Closed

Grape: route_xxx methods have been deprecated #364

ngonzalez opened this issue Apr 1, 2016 · 7 comments

Comments

@ngonzalez
Copy link

Grape Route model route_* methods have been deprecated
https://github.com/ruby-grape/grape/blob/master/lib/grape/router/route.rb#L100

Grape-Swagger still uses a lot of these methods, and the deprecation warnings can be annoying ..

@LeFnord
Copy link
Member

LeFnord commented Apr 1, 2016

yeap, this breaking change is known,
as I mentioned in the grape group
the adoption of it is planned for 0.21.0 release

@ngonzalez
Copy link
Author

@LeFnord Thanks

@dblock
Copy link
Member

dblock commented Apr 4, 2016

Do we want a 0.10.6 or 0.11.0 that locks a higher version of Grape and fixes the deprecations?

@LeFnord
Copy link
Member

LeFnord commented Apr 4, 2016

@dblock … think we should use 0.11.0 for grape >= 0.15.0 to indicate breaking change

@dblock
Copy link
Member

dblock commented Apr 4, 2016

Reopening this for a 0.11.0. It's a little more involved than I thought.

@pamit
Copy link

pamit commented May 1, 2016

This may fix this problem,

gem 'grape', '>= 0.16.2'
gem 'grape-entity', '< 0.5.0'
gem 'grape-swagger', '0.11.0'
gem 'grape-swagger-rails'#, '~> 0.0.8'

It works for me.

@dblock
Copy link
Member

dblock commented May 2, 2016

I'll close this, we have released compatible versions at this point. Understand that the matrix is a little complicated, but it gets better as we move forward. See https://github.com/ruby-grape/grape-swagger#version.

@dblock dblock closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants