Switch to GitHub Actions for CI and update dependencies #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies and appease the robot overlords, rubocop and danger.
samsonjs
commented
May 24, 2025
dblock
requested changes
May 25, 2025
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Looking good, let's enable these on PRs? See below.
Add a CI badge to README.
Collaborator
Author
|
Alright I think this puppy is good to go |
Member
|
Thanks @samsonjs! Want to help maintain this gem? Drop me an email with your rubygems to dblock at dblock dot org if you're down? |
This was referenced May 26, 2025
Collaborator
Author
|
Email incoming, I'm using this in production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops most unsupported Ruby versions but keeps 3.1.7 even though it's EOL since it's no burden to do so and it's been a while since any of this has changed. If someone really is using dependencies as old as the previous release they may need a branch to get into the modern day. It's probably easy to go back further if we want to.
Versions tested:
This also updates dependencies and applies all but one new rubocop rule, with the exception being the
frozen_string_literalmagic comment which I just find gross to be honest. It is being phased out slowly so the need for it is waning too. I'm happy to change any of the new rules of course, just let me know your preference.The changelog needed some massaging to appease danger. Apparently it doesn't like me being fancy and trying to use em-dashes or months spelled out. Anyway this all passed in my fork so I think it's a good starting point for discussion here.
Closes #97 and builds upon #96