Fix compatibility with Grape 2.3 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @samsonjs - I think we need to get CI back to going first, switch from Travis to GHA, want to help? I can help merge. |
Collaborator
Author
|
@dblock Yep you bet! Happy to help with CI |
|
Hi! Sorry for messaging on a merged PR, but any chance we could get this version released? This is preventing us from upgrading grape to 2.3.0 :) |
Collaborator
Author
|
@gokuu No worries and yes I'll be releasing 2.0 today or tomorrow |
Collaborator
Author
|
@gokuu 2.0 is out now with this fix |
|
Thanks for the quick release! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change and I think it would make sense to bump the version to 2.0 instead of continuing with 1.x.
Closes #94