Skip to content

make sure git diff doesn't print out with colors #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2017

Conversation

thatkookooguy
Copy link
Contributor

resolves #30

@rtfpessoa
Copy link
Owner

That case only works for the default diff2html, if you define something after -- it will not pass the option.
You need to check the first if case. Might be nice to check if the args passed already include it and if not add it.

@thatkookooguy
Copy link
Contributor Author

tested locally (by installing with npm install -g https://github.com/Thatkookooguy/diff2html-cli.git#patch-1).
But you know this code better than me. So you might want to check edge cases that I didn't think about :-)

@rtfpessoa
Copy link
Owner

Sorry for the delay. LGTM 👍

@rtfpessoa rtfpessoa merged commit 1aff14f into rtfpessoa:master Dec 30, 2017
@rtfpessoa
Copy link
Owner

Released as 2.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

something seems to be broken when using git HEAD^
2 participants