something seems to be broken when using git HEAD^

[thatkookooguy]

when I try to run diff2html HEAD^
it opens the web browser and says it found 0 changes

when I try to run pretty-diff HEAD^
it shows me the correct diff

Not sure what's wrong but seems like something is broken

Platform: MacBook Pro (Retina, 15-inch, Mid 2014) macOS Sierra 10.12.6

[rtfpessoa]

You need to run 'diff2html -- HEAD^'. Notice the --.

On Mon, 25 Dec 2017 at 13:18, Neil Kalman ***@***.***> wrote: when I try to run diff2html HEAD^ it opens the web browser and says it found 0 changes when I try to run pretty-diff HEAD^ it shows me the correct diff Not sure what's wrong but seems like something is broken Platform: MacBook Pro (Retina, 15-inch, Mid 2014) macOS Sierra 10.12.6 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3E8MFek8_FO4lFE4NjxUZPSizYrM_Kks5tD6CPgaJpZM4RMSwO> .

-- Best, Rodrigo

[thatkookooguy]

still nothing when running with diff2html -- HEAD^

[rtfpessoa]

That is quite weird, I cannot seem to replicate that even in the same OS.

Still, you can always do git diff HEAD^ | diff2html -i stdin.

[thatkookooguy]

git diff HEAD^ | diff2html -i stdin still opens the web browser with Files changed (0)

git diff HEAD^ do return an output

and here's the output for pretty-diff HEAD^:

I have 6 changed files and 1 new file. don't know if that helps, just thought about throwing everything out there :-)

[rtfpessoa]

Then, send me version you are using (diff2html --version) and the file output of git diff HEAD^ > example.diff so I can check.

[thatkookooguy]

version: 2.5.3

and here's the example.diff file

btw, same thing happens when I try and run diff2html -i file -- example.diff with the file I created

[rtfpessoa]

Did you copy the output from your terminal, or did you pipe it like I said in the previous message?

I ask that because the output has color codes from your terminal which are definitely making the diff unusable.

Also do you have any kind of .gitconfig?

[thatkookooguy]

used the command you sent me

yes, I have a .gitignore file in my repo.

here is the public repo I'm working on: https://github.com/Kibibit/kibibit-cli

I also committed the changes I have locally to a branch called diff2html so you can check out my specific changes. Maybe you'll be able to reproduce it with the same files + same changes
Kibibit/kibibit-cli@be07fc8

[thatkookooguy]

well.... I figured out from your answer that the colors mess things up.

tried running git diff --no-color HEAD^ | diff2html -i stdin and everything worked as expected

[rtfpessoa]

You must have something like color.ui=always in $HOME/.gitconfig. try changing to color.ui=auto

[thatkookooguy]

@rtfpessoa no, I don't unfortunately :-) (don't have any setting for color in my $HOME/.gitconfig)

but I think it will be good practice to add that flag (--no-color) to diff2html. It shouldn't break if colors are enabled in any way.

opened a PR with the flag added.