-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken build in travis-ci and fix tests #249
Conversation
Now all checks have been passed. But there is some problem with zuul and saucelab.com. I think that some time ago there was some sort of free plan on saucelabs.com, but now there is no anything like that. There is only free trial for 14 days. @rtfeldman I have deleted checks for different browsers because they prevented green build on travis-ci. Should we find other alternatives to saucelabs.com or can we merge this pr in the current shape? |
There's still supposed to be some sort of free plan on saucelabs.com for open source projects (especially libraries): https://saucelabs.com/open-source/open-sauce https://saucelabs.com/open-source |
@seanf I still hope that someone of the maintainers will come here and sort it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just two dependency versions that should be locked.
I'll merge after those are fixed. Better to have the build working and then we can look at the browser status later.
package.json
Outdated
@@ -10,11 +10,12 @@ | |||
"coveralls": "2.11.8", | |||
"deep-equal": "1.0.1", | |||
"envify": "3.4.0", | |||
"grunt": "0.4.5", | |||
"grunt": "^1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock the version as with the other dependencies.
package.json
Outdated
"grunt-contrib-uglify": "0.11.1", | ||
"grunt-mocha-test": "0.12.7", | ||
"istanbul": "0.4.2", | ||
"jscheck": "0.2.0", | ||
"jshint": "^2.9.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock the version as with the other dependencies.
fixed |
@crudh ping |
@myshov great! I just want to sync with the repo owner before I start merging stuff, I just got the collaborator invite last week. |
@myshov thanks, I'll merge it now. Lets keep the zuul dependency and scripts for now until we either fix it or remove it later. |
I just don't like the red label in the readme file
build:failed
. :)This pr fix this issue.