Fix for AMD & Symbol polyfill race condition #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
There is a race condition when using AMD for older browsers that use a Symbol polyfill. https://github.com/rtfeldman/seamless-immutable/blob/7.1.3/src/seamless-immutable.js#L7 this line detects whether a Symbol polyfill is used. However,
immutableInit
is called outside ofdefine
for AMD (https://github.com/rtfeldman/seamless-immutable/blob/7.1.3/src/seamless-immutable.js#L742).If a polyfill is in a separate bundle than Seamless, there is a race condition, and if Seamless loads before the polyfill, browsers that use the polyfill crash, because they don't break early on React elements.
Fix
immutableInit
inside define, fixing race condition.master
spec's don't pass in CI.