Skip to content

Sort tasks based on the recent time entries#710

Merged
niraj2477 merged 31 commits intomainfrom
develop
Aug 4, 2025
Merged

Sort tasks based on the recent time entries#710
niraj2477 merged 31 commits intomainfrom
develop

Conversation

@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator

@Siddhantsingh1230 Siddhantsingh1230 commented Aug 4, 2025

Description

This PR includes the following fixes/updates:

  • Fixes the currencyFormat utility to correctly display currency values.
  • Resolves the vertical infinite scroll issue on the Project page.
  • Adds minor style improvements related to tags.
  • Updates task list sorting logic during timesheet creation:
    • Prioritizes tasks based on recent activity.
    • Takes user preferences into account.
    • Considers task status to improve relevance and usability.

Relevant Technical Choices

  • Update currencyFormat utility to dynamically format currencies based on their locale and standards, instead of hardcoding en-IN for all cases.
  • Fix tag and currency input styles for form-view components

Updated Sorting Order:

  • Recently Worked On Tasks – Tasks that were logged in the past 7 days are now shown at the top.
  • Liked Tasks – Tasks marked as liked by the current user appear next.
  • Open / Working Tasks – Tasks that are still active (status = Open or Working) are shown afterward.

Testing Instructions

  • Visit NPMS
  • Navigate to the Project page
  • Scroll horizontally to the far right, then scroll to the bottom — projects should load regardless of horizontal scroll position
  • Locate the column displaying amount or currency values
  • Inspect these values to ensure they are formatted correctly with proper commas and currency symbols

Additional Information:

None

Screenshot/Screencast

Fix.Vertical.Scroll.and.Currency.Formats.webm
sorting-1754288588054.mp4

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes: https://github.com/rtCamp/erp-rtcamp/issues/2445, https://github.com/rtCamp/erp-rtcamp/issues/2444, #691, #679

maharrshi and others added 30 commits July 23, 2025 21:54
Added readme file for visual regression tests
Fix Currency format and vertical scroll in project page
Sort tasks based on the recent time entries
@Siddhantsingh1230 Siddhantsingh1230 changed the title Fix Currency format and vertical scroll in project page Fix currency format and vertical scroll in project page and sort tasks based on the recent time entries Aug 4, 2025
@Siddhantsingh1230 Siddhantsingh1230 changed the title Fix currency format and vertical scroll in project page and sort tasks based on the recent time entries Fix currency format and vertical scroll and sort tasks based on the recent time entries Aug 4, 2025
@niraj2477 niraj2477 changed the title Fix currency format and vertical scroll and sort tasks based on the recent time entries Sort tasks based on the recent time entries Aug 4, 2025
@niraj2477 niraj2477 merged commit 2095435 into main Aug 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants