Skip to content

Fix Currency format and vertical scroll in project page#706

Merged
Siddhantsingh1230 merged 5 commits intodevelopfrom
fix/project-vertical-scroll
Aug 4, 2025
Merged

Fix Currency format and vertical scroll in project page#706
Siddhantsingh1230 merged 5 commits intodevelopfrom
fix/project-vertical-scroll

Conversation

@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator

Description

This PR fixes the currencyFormat utility to display the correct currency format, resolves the vertical infinite scroll issue on the Project page, and includes minor style improvements related to tags.

Relevant Technical Choices

  • Update currencyFormat utility to dynamically format currencies based on their locale and standards, instead of hardcoding en-IN for all cases.
  • Fix tag and currency input styles for form-view components

Testing Instructions

  • Visit NPMS
  • Navigate to the Project page
  • Scroll horizontally to the far right, then scroll to the bottom — projects should load regardless of horizontal scroll position
  • Locate the column displaying amount or currency values
  • Inspect these values to ensure they are formatted correctly with proper commas and currency symbols

Additional Information:

None

Screenshot/Screencast

Fix.Vertical.Scroll.and.Currency.Formats.webm

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes: https://github.com/rtCamp/erp-rtcamp/issues/2445, https://github.com/rtCamp/erp-rtcamp/issues/2444

@Siddhantsingh1230 Siddhantsingh1230 merged commit 74aa5ed into develop Aug 4, 2025
7 of 8 checks passed
@Siddhantsingh1230 Siddhantsingh1230 deleted the fix/project-vertical-scroll branch August 7, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants