Skip to content

Add Column Pinning, Custom View Controls & Fix Costing Rate Calculation#683

Merged
zeel-codder merged 44 commits intomainfrom
develop
Jul 14, 2025
Merged

Add Column Pinning, Custom View Controls & Fix Costing Rate Calculation#683
zeel-codder merged 44 commits intomainfrom
develop

Conversation

@zeel-codder
Copy link
Copy Markdown
Collaborator

@zeel-codder zeel-codder commented Jul 11, 2025

Description

This PR introduces multiple improvements in the Next-PMS app:

  • Pinned Columns Support: Enables users to pin columns in tables for improved usability and control over layout.
  • Custom View Visibility: Adds support for deleting custom views and toggling their visibility between private and public.
  • Employee Costing Rate Update: Refactors the get_employee_costing_rate function in next_pms/project_currency/overrides/timesheet.py by introducing a new parameter for salary calculation and removing currency conversion logic for simplification.

The following changes have also been completed as part of this PR:

  • Updated approval message to: "Timesheet approval or rejection has been queued for processing. Please do not make any changes to it. You may continue with other tasks."
  • Fields in the Project detail page now support values up to 2 decimal places
  • Fixed leave allocation styling in Resource Timeline view for dark mode
  • Add fallback icon to viewloader in sidebar

Relevant Technical Choices

  • Add Pinned Columns in PMS View Settings doctype to store i.e Array of strings

Updates to employee costing rate calculation:

  • Added the date parameter (start_date) to the salary calculation function call, ensuring that the calculation is date-specific.
  • Removed the logic for converting the salary currency to the project currency, simplifying the function by eliminating the use of get_exchange_rate.

Testing Instructions

  • Go to NPMS
  • Try Pinning columns in Project and Task page
  • Try Creating views , make private views public or delete them

Additional Information:

Public views cannot be deleted or changed back to private from NPMS.

Screenshot/Screencast

Resource Timeline:
image

Project Detail
image

Fallback Icon in ViewLoader
image

Column.pinning.webm

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Addresses: https://github.com/rtCamp/erp-rtcamp/issues/2394

jayson31 and others added 30 commits July 1, 2025 15:18
@zeel-codder zeel-codder changed the title Develop Fix calculation to apply amount conversion only once for costing rate Jul 11, 2025
@zeel-codder zeel-codder requested a review from niraj2477 July 11, 2025 12:24
@zeel-codder zeel-codder changed the title Fix calculation to apply amount conversion only once for costing rate Develop Jul 11, 2025
niraj2477 and others added 2 commits July 14, 2025 14:13
Prevent date modification from erp backend
Add Column Pinning and support deleting & changing visibility of custom views
@Siddhantsingh1230 Siddhantsingh1230 changed the title Develop Add Column Pinning, Custom View Controls & Fix Costing Rate Calculation Jul 14, 2025
@zeel-codder zeel-codder merged commit b56071c into main Jul 14, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants