Fix calculation to apply amount conversion only once for costing rate#682
Merged
zeel-codder merged 1 commit intodevelopfrom Jul 11, 2025
Merged
Fix calculation to apply amount conversion only once for costing rate#682zeel-codder merged 1 commit intodevelopfrom
zeel-codder merged 1 commit intodevelopfrom
Conversation
niraj2477
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
get_employee_costing_ratefunction innext_pms/project_currency/overrides/timesheet.pyto improve its handling of employee costing rates. The changes focus on adding a new parameter to the salary calculation and simplifying the logic by removing currency conversion.Updates to employee costing rate calculation:
dateparameter (start_date) to the salary calculation function call, ensuring that the calculation is date-specific.get_exchange_rate.Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist