Skip to content

Fix calculation to apply amount conversion only once for costing rate#682

Merged
zeel-codder merged 1 commit intodevelopfrom
fix/billing-edge-case
Jul 11, 2025
Merged

Fix calculation to apply amount conversion only once for costing rate#682
zeel-codder merged 1 commit intodevelopfrom
fix/billing-edge-case

Conversation

@zeel-codder
Copy link
Copy Markdown
Collaborator

Description

This pull request updates the get_employee_costing_rate function in next_pms/project_currency/overrides/timesheet.py to improve its handling of employee costing rates. The changes focus on adding a new parameter to the salary calculation and simplifying the logic by removing currency conversion.

Updates to employee costing rate calculation:

  • Added the date parameter (start_date) to the salary calculation function call, ensuring that the calculation is date-specific.
  • Removed the logic for converting the salary currency to the project currency, simplifying the function by eliminating the use of get_exchange_rate.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

@zeel-codder zeel-codder requested a review from niraj2477 July 11, 2025 06:36
@zeel-codder zeel-codder merged commit b3c4efe into develop Jul 11, 2025
7 of 8 checks passed
@niraj2477 niraj2477 deleted the fix/billing-edge-case branch February 13, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants