Process time-entries in background on submit & reduce timesheet count in recalculation job#665
Merged
zeel-codder merged 38 commits intomainfrom Jun 30, 2025
Merged
Process time-entries in background on submit & reduce timesheet count in recalculation job#665zeel-codder merged 38 commits intomainfrom
zeel-codder merged 38 commits intomainfrom
Conversation
fix : included describe blocks in spec file
Fixed flaky tests and removed run in serial mode
…alary with respect to work scehdule
Remove formatting from reports
Update hourly salary calculation
Fix : updated from json to js files to use env variables easily
Fix zero float devision error in custom field patch
Fix word break in text-editor component
…/weekly-status
…into fix/weekly-status
Reduce the timesheet count in recalculation job
Process time-entries in background when submitted
…timesheet_detail API
Add Approval pending Status and fix get_timesheet_detail API
Update e2e-playwright-test.yml
niraj2477
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the timesheet approval process by moving timesheet approval process to the background, reducing frontend wait time. It refactors the weekly status and hourly salary calculation logic to use a unified method that respects employee work schedules. Additional improvements include: reducing job chunk size (2000 → 300), setting job timeout to 1h, fixing a zero float division error in a custom field patch, and resolving word break issues in the text-editor tooltip when hovering over timesheets.
Relevant Technical Choices
Return if total is 0"break-all"tailwind class to avoid word breaking in TextEditor componentTesting Instructions
Additional Information:
Screenshot/Screencast
Checklist
Fixes #641