Skip to content

Process time-entries in background on submit & reduce timesheet count in recalculation job#665

Merged
zeel-codder merged 38 commits intomainfrom
develop
Jun 30, 2025
Merged

Process time-entries in background on submit & reduce timesheet count in recalculation job#665
zeel-codder merged 38 commits intomainfrom
develop

Conversation

@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator

@Siddhantsingh1230 Siddhantsingh1230 commented Jun 30, 2025

Description

This PR optimizes the timesheet approval process by moving timesheet approval process to the background, reducing frontend wait time. It refactors the weekly status and hourly salary calculation logic to use a unified method that respects employee work schedules. Additional improvements include: reducing job chunk size (2000 → 300), setting job timeout to 1h, fixing a zero float division error in a custom field patch, and resolving word break issues in the text-editor tooltip when hovering over timesheets.

Relevant Technical Choices

  • Add a check for total: Return if total is 0
  • Conditionally use "break-all" tailwind class to avoid word breaking in TextEditor component
  • Update common method to work based on the employee schedule.

Testing Instructions

  • Execute the patch using bench execute
  • Create long text timesheet (Try this: Debug the child table render issue in webform, Debug child table render issue in webform)
  • Hover above the newly created timesheet
  • Text Content should not break

Additional Information:

N/A

Screenshot/Screencast

image

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes #641

maharrshi and others added 30 commits June 20, 2025 19:48
fix : included describe blocks in spec file
Fixed flaky tests and removed run in serial mode
Fix : updated from json to js files to use env variables easily
Fix zero float devision error in custom field patch
Fix word break in text-editor component
maharrshi and others added 3 commits June 30, 2025 17:10
Add Approval pending Status and fix get_timesheet_detail API
Update e2e-playwright-test.yml
@zeel-codder zeel-codder merged commit a17d173 into main Jun 30, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with Word Break in Time Entry Hover Details Section

5 participants