Add Approval pending Status and fix get_timesheet_detail API#664
Merged
Add Approval pending Status and fix get_timesheet_detail API#664
Conversation
…timesheet_detail API
niraj2477
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check for the "Approval Pending" weekly status. If the total hours marked as "Approval Pending" exceed the employee's working hours, editing the timesheets will no longer update the weekly status. Additionally, an issue where cancelled documents were visible in the "Edit Timesheet" dialog has been fixed.
Relevant Technical Choices
Approval PendingStatus CountTesting Instructions
Additional Information:
Screenshot/Screencast
Checklist