Conda mode deprecated from rsconnect-python pkg #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelizimm
reviewed
Oct 19, 2023
Contributor
There was a problem hiding this comment.
Ah, thanks for this 🙌 do you all know what version number this will be implemented in? I may want to pin a compatible version (or do some other error handling) and queue it up to have a fast follow from your release. 😄
FYI: the docs breaking are unrelated to your change, it's due to the changes coming from a fork
Contributor
Author
|
@isabelizimm Looks like the release will be this month, so I'm expecting it will be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In association with PR: posit-dev/rsconnect-python#412, the
conda_modeparam is soon to been deprecated. It is still being accepted for the methoddeploy_python_fastapi, but it will not do anything. It is expected to be removed in the future. Passingtruefor this parameter wasn't really supported as Connect has not supported condo environment restoration.Per the issue referenced above:
This PR fixes: #196