[FEAT] add new /metadata GET endpoint
#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelizimm
commented
Apr 12, 2023
| async def ping(): | ||
| return {"ping": "pong"} | ||
|
|
||
| @app.get("/metadata") |
Contributor
Author
There was a problem hiding this comment.
This was, in fact, pretty small to add! But now I wonder if we need to expose prototypes as well?
Member
There was a problem hiding this comment.
I think that would be a nice addition, while we're working on the API, but let's add it with an argument (for folks with high data privacy needs). I think opt-out (so defaulting to adding the prototype endpoint) is OK for this.
juliasilge
approved these changes
Apr 13, 2023
Member
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
This looks great!
When I made the similar change in rstudio/vetiver-r#194, I realized that some of my testing strategy for model types was a little bonkers 🙈 but I hopefully improved it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #169