-
Notifications
You must be signed in to change notification settings - Fork 18
ENH: Refactor server handling #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
has2k1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to merge. The improvements can come afterwards. The important one is, full type-annotations that pass a type checker. It would make clearer how the input data, output data and api data are juggled.
| @@ -1,4 +1,3 @@ | |||
| from vetiver.handlers import base | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this (or immediately after this PR) is the good time to add a module docstring for all the whats and the whys about Handlers. I will do a PR after this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! That would be a great addition for more context on Handlers.
Added in this PR
vetiver_postvetiver/tests/test_predict.pyandvetiver/tests/test_sklearn.py)previous error message:
new error message:
where 0 is the index of the error and
dispis the feature with the errorRelated Issues
rsconnect.api.RSConnectServer#152Notes
This PR must be merged before #143 since spacy's input data of one column of strings cannot be handled in the same way as tabular data, and the output might be multiple columns. This PR gives the flexibility of input/output handling to each modeling framework's handler.