Disable completion of R code inside quotes, closes #401 #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
changed the title
schloerke
reviewed
Aug 3, 2020
schloerke
approved these changes
Aug 3, 2020
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
LGTM given suggestion!
Co-authored-by: Barret Schloerke <barret@rstudio.com>
schloerke
approved these changes
Aug 3, 2020
cpsievert
commented
Aug 4, 2020
schloerke
added a commit
that referenced
this pull request
Aug 7, 2020
* master: Disable completion of R code inside quotes, closes #401 (#413) Bump version (#414) Save tutorial output to temp folder when tutorial folder does not have write permissions (#412) Throw an informative error if an exercise chunk is NULL (#411) Remove outdated exercise option Checking for exercise errors (#403)
schloerke
added a commit
that referenced
this pull request
Sep 2, 2020
* master: Add events to website (#423) Add a checker test with error as solution (#422) Fixes for learnr on external evaluator (#420) Add shinytest support (#407) Validate the ability to create an idb store (#417) Disable completion of R code inside quotes, closes #401 (#413) Bump version (#414) Save tutorial output to temp folder when tutorial folder does not have write permissions (#412) Throw an informative error if an exercise chunk is NULL (#411) Remove outdated exercise option Checking for exercise errors (#403) Add event handler system (#398) External evaluator fixes (#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #401 for motivation.
This disables completion of R code inside quotes (when
exercise.completion = TRUE), by settingquotes = FALSEinrc.settings()...the docs forquotessays:Thus, this might be a slightly over-agressive way to prevent filenames from being displayed. Note that there is also a
filesargument that we could set toFALSE, but for some reason that arg is deprecated (maybe it's effectively the same asquotes?)