Add tests and fix for ruby 3 keyword arguments issues

[jhottenstein]

I recently ran into a similar issue to #1396 when upgrading our codebase to ruby 3.

This PR adds tests for both scenarios (receive with a block with kwargs and and_call_original when mocking a method that uses keyword arguments). The tests may be redundant since fixing recorder fixed both tests.

I noticed other spots where define_method is used to intercept method calls (e.g.

rspec-mocks/lib/rspec/mocks/any_instance/chain.rb

Line 27 in 0a52e0a

define_method(method_name) do |*args, &block|

and

rspec-mocks/lib/rspec/mocks/matchers/receive.rb

Line 61 in 0a52e0a

define_method(method) do |*args, &block|

) so this PR may not be sufficient to fix all keyword argument issues

[JonRowe]

Thanks for tackling this, you need to wrap the specs in eval blocks so that they can safely be ignored by legacy Rubies. Theres examples around of this in #1385

[jhottenstein]

Thanks for the review and the pointer. I was unsure how rspec handled keyword args and legacy rubies.

Do you want me to add more specs for keyword args in the other spots that I highlighted? Our codebase didn't run into issues with those spots but I'm happy to attempt a reproduction or add more keyword argument tests in general.

[JonRowe]

Do you want me to add more specs for keyword args in the other spots that I highlighted? Our codebase didn't run into issues with those spots but I'm happy to attempt a reproduction or add more keyword argument tests in general.

More keyword specs in examples are welcome, we are lacking that aspect of coverage, although I'd prefer a seperate PR for general keyword examples, and focus this on your fix 👍

[JonRowe]

This looks great apart from the JRuby failures, can you investigate?

[headius]

Was this fix really for JRuby? If we are differing on some language-level behavior compared to an equivalent CRuby, we definitely would like to see a bug report for that.

Edit: referring to 740046b

[jhottenstein]

@JonRowe It was a bad test setup. wrapped can be expect/allow or expect_any_instance_of/allow_any_instance_of. A block implementation cannot be shared between those cases when yield_receiver_to_any_instance_implementation_blocks is true.

I set it to false for the test that pass block implementations. I could move the test into the individual blocks (allow(...).to receive/expect(...).to receive/allow_any_instance_of.to receive/expect_any_instance_of.to receive

[jhottenstein]

@headius, I can write something up. Let me create a simpler repro.

[JonRowe]

Thanks 🙏

[dorner]

@JonRowe can we push a release for this? Currently upgrading to Ruby 3 breaks a whole lot of specs.

[JonRowe]

A release is planned but I have to fix some CI issues first.

[JonRowe]

Released as v3.10.2

[dorner]

Awesome, thanks!