Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rrweb, rrweb-snapshot, rrweb-player into a mono repository #595

Merged
merged 353 commits into from
Jul 23, 2021
Merged

Merge rrweb, rrweb-snapshot, rrweb-player into a mono repository #595

merged 353 commits into from
Jul 23, 2021

Conversation

YunFeng0817
Copy link
Member

  1. In this PR, I use yarn workspaces to link multiple packages.
  2. Update Travis-CI config.

Related issue #582

@YunFeng0817
Copy link
Member Author

This PR is almost done except for a build warning.
Tips:

  1. Because we want to keep the commit history of the other two projects, the number of commits in this PR may be a little too much. And because of the same reason, when merging this PR, we should avoid the squash operation.
  2. I think we can keep using yarn workspace as our package manager for now and it's not hard to replace it with another manager if yarn can't meet our requirement later.
  3. There's still a build warning as follows in the rrweb-player package.
(!) Unresolved dependencies
[https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency](https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency)
rrweb (imported by src/Player.svelte, src/Controller.svelte)
(!) Missing global variable name
Use output.globals to specify browser global variable names corresponding to external modules
rrweb (guessing 'rrweb')
created public/bundle.js in 1.8s

It seems like its rollup config doesn't fit for monorepo environment and any help would be great.

Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good @Mark-Fenng! I found some very minor outdated urls, but apart from that this looks good!

packages/rrweb-snapshot/README.md Outdated Show resolved Hide resolved
packages/rrweb-snapshot/package.json Outdated Show resolved Hide resolved
packages/rrweb-snapshot/package.json Outdated Show resolved Hide resolved
packages/rrweb-player/package.json Outdated Show resolved Hide resolved
packages/rrweb-player/package.json Outdated Show resolved Hide resolved
packages/rrweb-player/package.json Outdated Show resolved Hide resolved
@Yuyz0112
Copy link
Member

Nice! Let's go.

I think contributors may see some conflicts in their existing PRs, we can help them get things done again.

And I'm going to check the rollup things and update the release script.

Awesome work.

@Yuyz0112 Yuyz0112 merged commit bdd8695 into rrweb-io:master Jul 23, 2021
@YunFeng0817 YunFeng0817 deleted the monorepo branch August 6, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.