-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rrweb, rrweb-snapshot, rrweb-player into a mono repository #595
Conversation
* Make block class optional * Fix test by removing unexpected space space
Fix progress bar height
* handle quoted strings in data url * unrefactor * update package json * Revert "update package json" This reverts commit 9446109b0f94d9e569a961642f1e57b1a67793ee. * change background-image to border-image
Enables Source maps for the library
Allow goto to specify if it should play or pause
….17.21 Bump lodash from 4.17.19 to 4.17.21
Add Vue.js version link to readme file
This PR is almost done except for a build warning.
It seems like its rollup config doesn't fit for monorepo environment and any help would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good @Mark-Fenng! I found some very minor outdated urls, but apart from that this looks good!
Nice! Let's go. I think contributors may see some conflicts in their existing PRs, we can help them get things done again. And I'm going to check the rollup things and update the release script. Awesome work. |
Related issue #582