-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rrweb-snapshot into rrweb #582
Comments
yes, monorepo is a good idea. |
Oh man, Yes please! |
In this topic, the rrweb-player suffers from the same issue. Maybe it would be a good idea to also merge that into the same repo? |
I believe the decision to merge should be done before a 1.0 release. |
@ucjonathan I think we can keep the compatibility of public APIs. So maybe it's not a blocker of 1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The two projects are very closely coupled. I have a custom setup where I have site specific commits living on top of both rrweb and rrweb-snapshot. As such I don't use the regular NPM inclusion of rrweb-snapshot.
snapshot
serializeNodeWithId
etc. (this is particularly hard when you are not pulling rrweb-snapshot from NPM but are compiling a local version of rrweb-snapshot)I imagine rrweb-snapshot was originally a separate project with the idea that it could be used in other projects. Would preserving the separate rrweb-snapshot NPM library still maintain this goal? I.e. if the rrweb-snapshot NPM library could be an export target for a new combined repository?
The text was updated successfully, but these errors were encountered: