Skip to content

Add/Fix support to outputting to Image Sources #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aapokaapo wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add/Fix support to outputting to Image Sources #133

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a33de83
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
53e79f1
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
998b06c
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
c86ddff
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
643fee1
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
d1fa141
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
7ff4c3d
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
7c3edb2
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
468d05c
Update url-source-callbacks.cpp
aapokaapo Feb 9, 2025
b9d88db
Update src/url-source-callbacks.cpp
royshil Nov 13, 2025
cab0004
Update src/url-source-callbacks.cpp
royshil Nov 13, 2025
06a762c
Update src/url-source-callbacks.cpp
royshil Nov 13, 2025
95e0f96
Merge branch 'royshil:master' into master
aapokaapo Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/url-source-callbacks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,20 @@ void setTextCallback(const std::string &str, const output_mapping &mapping)
obs_data_set_string(target_settings, "input", str.c_str());
obs_data_set_bool(target_settings, "looping", false);
} else {
// if the target source is a text source - set the text field
obs_data_set_string(target_settings, "text", str.c_str());
// if target source is an image source - set the file path from the provided string (expected to be a file path or URL)
// TODO: allow only strings that end with an image extension to avoid OBS crashing
Copy link
Owner

@royshil royshil Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot implement the image extension check

if (strcmp(obs_source_get_id(target), "image_source") == 0) {
// if file path has not changed, do not update it
if (strcmp(obs_data_get_string(target_settings, "file"), str.c_str()) == 0) {
obs_data_release(target_settings);
obs_source_release(target);
return;
}
obs_data_set_string(target_settings, "file", str.c_str());
} else {
// if the target source is a text source - set the text field
obs_data_set_string(target_settings, "text", str.c_str());
}
}
obs_source_update(target, target_settings);
if (mapping.unhide_output_source) {
Expand Down
Loading