Add/Fix support to outputting to Image Sources#133
Open
aapokaapo wants to merge 13 commits intoroyshil:masterfrom
Open
Add/Fix support to outputting to Image Sources#133aapokaapo wants to merge 13 commits intoroyshil:masterfrom
aapokaapo wants to merge 13 commits intoroyshil:masterfrom
Conversation
Add support to push the image URL to OBS-Image source
fixed intendation
missing ; on line 58, fixed
if file path has not changed, do not update it
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for outputting image URLs to OBS Image Sources by detecting the image_source type and setting the appropriate file property instead of the text property used for text sources.
- Adds conditional logic to detect and handle image sources separately from text and media sources
- Implements an optimization to skip updates when the file path hasn't changed
- Includes a TODO note about validating image file extensions to prevent OBS crashes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
royshil
reviewed
Nov 15, 2025
| // if the target source is a text source - set the text field | ||
| obs_data_set_string(target_settings, "text", str.c_str()); | ||
| // if target source is an image source - set the file path from the provided string (expected to be a file path or URL) | ||
| // TODO: allow only strings that end with an image extension to avoid OBS crashing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds/fixes the support to outputting image URLs to OBS Image Sources