This repository was archived by the owner on Jan 14, 2023. It is now read-only.
Action generation #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
reviewed
Aug 31, 2018
package.xml
Outdated
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0"?> | |||
| <package> | |||
| <name>rosjava_bootstrap</name> | |||
| <version>0.3.2</version> | |||
| <version>0.3.3</version> | |||
There was a problem hiding this comment.
Would you please remove this change? We usually bump the version in a separate commit with a short description in the changelog.
If this code is already working for you, I can do that right after this PR.
exo-core
force-pushed
the
action-generation
branch
from
edfe2b9 to
5a2cdcb
Compare
|
Reverted that commit. Thought that new feature was worth increasing the number a little 😜 |
jubeira
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make some more adjustments to make the generated messages compatible with
actionlib.There are two messages generated per action part (
goal,result,feedback):.actionfile (e.g.<ACTION_NAME>Goal)HeaderandGoalId/GoalStatus). This on is then named<ACTION_NAME>ActionGoaland used for the communication.I was now able to run a successful test with an action server based on ernestmc's rosjava_actionlib on our KUKA Sunrise cabinet (robot controller) together with a actionlib
axclient.pyon my PC. 😄