Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROSIDL enum support #20

Closed
wants to merge 1 commit into from
Closed

Add ROSIDL enum support #20

wants to merge 1 commit into from

Conversation

r7vme
Copy link

@r7vme r7vme commented Jun 24, 2022

Signed-off-by: Roman Sokolkov roman.sokolkov@apex.ai

Main PR ros2/rosidl#685

Related issue ros2/rosidl#260

Signed-off-by: Roman Sokolkov <roman.sokolkov@apex.ai>
@r7vme r7vme marked this pull request as ready for review June 27, 2022 10:38
@r7vme
Copy link
Author

r7vme commented Jun 27, 2022

@audrow could you please take a look?

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:25
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/need-reviewers-for-rosidl-related-change/26285/1

@audrow
Copy link
Member

audrow commented Jul 12, 2022

Here's CI to get us started:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but let's make sure than this and the related PR don't break things downstream.

@r7vme
Copy link
Author

r7vme commented Aug 1, 2022

@audrow thanks for review, I fixed header names in this PR. I was able to reproduce the problem locally, seems I renamed Enums.idl to EnumsMessage.idl at some point. However, this job is still failing with

10:50:19 /tmp/ws/src/rosidl/rosidl_generator_c/test/test_interfaces.c:28:10: fatal error: rosidl_generator_c/idl/enums_message.h: No such file or directory
10:50:19    28 | #include "rosidl_generator_c/idl/enums_message.h"
10:50:19       |         

Locally I was able to compile successfully whole ros2 workspace with my forks.

@r7vme
Copy link
Author

r7vme commented Aug 2, 2022

@audrow do you know may be some ROS working group , where I can present this feature and may be get some feedback?

@audrow
Copy link
Member

audrow commented Aug 2, 2022

@audrow do you know may be some ROS working group , where I can present this feature and may be get some feedback?

Maybe the Middleware Working Group? @wjwwood or @clalancette, any thoughts?
https://docs.ros.org/en/rolling/The-ROS2-Project/Governance.html#working-groups-wgs

@r7vme
Copy link
Author

r7vme commented Aug 3, 2022

Thanks @audrow. Could you please rerun CI like you did here? #20 (comment)

@methylDragon
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@methylDragon
Copy link

I suspect the job failing is happening because this PR hasn't been merged yet. If CI comes up happy we can merge this and 🤞

@r7vme
Copy link
Author

r7vme commented Aug 15, 2022

@methylDragon thanks, we discovered issue with ROS Services support and currently working on it. I'll ping you, folks, as soon as it will be ready.

@r7vme
Copy link
Author

r7vme commented Jan 9, 2023

Closing as I have no plans to work on this in the near time (see more details here).

@r7vme r7vme closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants