Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashing backports #223

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

mikaelarguedas
Copy link
Member

Backport and adapt #219 to dashing
Backport #179

backport and adaptation of ros2#219 to eloquent

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
….xml (ros2#179)

* update maintainer and fix invalid package.xml

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* use format 3 for consistency and futureproofness

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikaelarguedas!

@kyrofa kyrofa requested a review from a team June 16, 2020 20:10
Copy link

@artivis artivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mikaelarguedas mikaelarguedas merged commit 3cf592c into ros2:dashing Jun 17, 2020
@mikaelarguedas mikaelarguedas deleted the dashing_backports branch June 17, 2020 07:42
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-06-18/14948/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants