Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashing/Eloquent] List keys doesn't list nested keys #183

Closed
ivanpauno opened this issue Mar 26, 2020 · 5 comments · Fixed by #219
Closed

[Dashing/Eloquent] List keys doesn't list nested keys #183

ivanpauno opened this issue Mar 26, 2020 · 5 comments · Fixed by #219
Assignees
Labels
bug Something isn't working

Comments

@ivanpauno
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04 (should happen in any)
  • Installation type:
    • from source (should happen in any)
  • Version or commit hash:
    • master
  • DDS implementation:
    • N/A
  • Client library (if applicable):
    • N/A

Steps to reproduce issue

ros2 security generate_artifacts -k tmp -n /node1 /ns/node1 /ns/node2
ros2 security list_keys tmp

Expected behavior

Output:

/node1
/ns/node1
/ns/node2

Actual behavior

Output:

node1
ns

Additional information

This should be fixed for Dashing/Eloquent, and also for Foxy after #177 is merged.
Add a regression test too.

@ivanpauno ivanpauno added the bug Something isn't working label Mar 26, 2020
@ivanpauno ivanpauno mentioned this issue Mar 26, 2020
7 tasks
@hidmic
Copy link
Contributor

hidmic commented Apr 9, 2020

@ros2/security_working_group are you planning to take a stab at this one in the near term e.g. before Foxy feature freeze?

@kyrofa
Copy link
Member

kyrofa commented Apr 9, 2020

Do the still-in-flux design updates impact this at all?

@ivanpauno
Copy link
Member Author

ivanpauno commented Apr 9, 2020

Do the still-in-flux design updates impact this at all?

The fixes for Dashing and Eloquent aren't blocked by those changes.
About Foxy, maybe contexts folder is renamed to enclaves, but it isn't a big deal to update the folder name in a follow up.

@ivanpauno ivanpauno changed the title List keys doesn't list nested keys [Dashing/Eloquent] List keys doesn't list nested keys Jun 4, 2020
@ivanpauno
Copy link
Member Author

Reopening to track the fix for Dashing/Eloquent

@ivanpauno ivanpauno reopened this Jun 4, 2020
@mikaelarguedas
Copy link
Member

Backported and released
Dashing: #223 ros/rosdistro#25499
Eloquent: #222 ros/rosdistro#25492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants