Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors from uncrustify v0.68 #366

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Fix errors from uncrustify v0.68 #366

merged 3 commits into from
Dec 21, 2018

Conversation

jacobperron
Copy link
Member

Connects to ros2/rosidl#340
Connects to ament/uncrustify_vendor#3

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Dec 19, 2018
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 19, 2018
@jacobperron jacobperron merged commit 4d5e94d into ros2 Dec 21, 2018
@jacobperron jacobperron deleted the uncrustify_v68 branch December 21, 2018 18:06
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Dec 21, 2018
wjwwood added a commit that referenced this pull request Dec 21, 2018
@wjwwood
Revert "Fix errors from uncrustify v0.68 (#366)"
6f52c7a 
This reverts commit 4d5e94d.
wjwwood added a commit that referenced this pull request Dec 21, 2018
@wjwwood
Revert "Visibility followup for marker" (#369)
712f903 
* Revert "Fix errors from uncrustify v0.68 (#366)"

This reverts commit 4d5e94d.

* Revert "Visibility followup for marker (#297)"

This reverts commit a47ceb6.
@wjwwood wjwwood mentioned this pull request Dec 21, 2018
Merged
@andreasholzner andreasholzner mentioned this pull request Jan 7, 2019
Merged
@clalancette clalancette mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @wjwwood