Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncrustify 0.68 does not accept line length 999 #340

Closed
jacobperron opened this issue Dec 18, 2018 · 0 comments
Closed

uncrustify 0.68 does not accept line length 999 #340

jacobperron opened this issue Dec 18, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • macOS
  • Installation type:
    • N/A
  • Version or commit hash:
    • Crystal
  • DDS implementation:
    • N/A
  • Client library (if applicable):
    • N/A

Steps to reproduce issue

With uncrustify v0.68 installed (default for macOS) we get errors for packages that use rosidl generators related to the code_width variable. E.g.:

    Option<UNUM>: at /var/folders/cl/kf4w4g450n14r3mvm95yt9tw0000gn/T/uncrustify_bc3goxjd:2241: requested value 999 for option code_width is greater than the maximum value 0
    Option<UNUM>: at /var/folders/cl/kf4w4g450n14r3mvm95yt9tw0000gn/T/uncrustify_bc3goxjd:2241: Expected unsigned number for code_width; got '999'
    Output prefix: /var/folders/cl/kf4w4g450n14r3mvm95yt9tw0000gn/T/uncrustify_1dbjacdr/
    Output suffix: .uncrustify

Expected behavior

No uncrustify errors.

Actual behavior

Uncrustify errors and test fails.

Additional information

An upper bound of 256 for the uncrustify option, code_width, was introduced in uncrustify/uncrustify#1852, specifically:

https://github.com/uncrustify/uncrustify/pull/1852/files#diff-0799bb9998b90a7d6cbaf9f6679b6938R2461

We are attempting to bypass any line length issues by passing a value of 999 in several places:

Along with other rosidl repos.


Looks like a solution for ignoring line length for generated files is to set code_width to 0.

@jacobperron jacobperron added the bug Something isn't working label Dec 18, 2018
@jacobperron jacobperron self-assigned this Dec 18, 2018
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Dec 18, 2018
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 19, 2018
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant