Display bag summary using ros2 bag info
#42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We currently only need to write files, but yaml-cpp basically wants to have both versions anyway (it also makes testing easier) - Only implements methods to write and read yaml via yaml-cpp
- This workaround is taken from rviz - upstream issue jbeder/yaml-cpp#461
get_metadata() returns the metadata that will be written to the metadata yaml file.
- Use interface to make writing optional in tests
- At the moment, there is no need to expose WriterImpl
The methods in metadata_io only receive the uri where the metadata.yaml file can be found in. This way the information on how to find the metadata file is contained in one place.
… write_metadata() and read_metadata()
Also adds CLI parameters for uri and storage id to record
File size should be determined dynamically when calling info()
…output of ros1 bag info
This moves all assertions into the test body and allows to also test for failures.
-Now it prints 0 B instead of 0.0 B
…use of localtime())
…est_common instead
… preferred by OSRF
Karsten1987
reviewed
Oct 10, 2018
There was a problem hiding this comment.
I am sorry, but I am not able to review this PR with the size as-is. There is too much stuff happening which is not related to Info.
Please consider closing this PR and opening multiple independent PRs.
From a first walk-through the 80 files, I see at least three possible PRs:
- Actual Info
- rosbag2 factory and changes related to reader and writer(impl)
- testing related stuff (sqlite3, etc.)
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this pull request
Nov 17, 2022
Incorporates fixes from foxglove/mcap#478 and foxglove/mcap#482 Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new ros2 bag CLI verb
infowhich prints a summary of a bag content.The printout looks like this:
These infos are stored in a metadata file at the end of the record process to allow getting infos about a bag without inspecting its content.
This is necessary since the user might not have access to the storage backend used to record the bagfile.
Some minor changes have been added in this PR as well:
This folder contains the
metadata.yamlfile as well as all files created by the storage backend.--outputto state the output file and--storageto select the storage backend.Default: Use the current timestamp as bag name and sqlite3 as storage backend
CI: