disable cppcheck #91
Merged
disable cppcheck #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't the code on the |
|
It will use the code eventually. I will copy the master branch to crystal and make a new release for it. Then update the master branch with the fixes in |
|
taking @dirk-thomas thumbs-up as implicit approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to an update of the ROS2 CI machines (OSX, Windows) cppcheck currently fails because we're using a rclcpp macro which is not verified by cppcheck.
the patch for cppcheck is here: ament/ament_lint#125
given that this patch most likely won't be backported to crystal, this PR explicitly disables cppcheck.
CI: