Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2interface] Remove usage of deprecated std_msgs and std_srvs packages #516

Merged
merged 2 commits into from
May 22, 2020

Conversation

jacobperron
Copy link
Member

Packages were deprecated in ros2/common_interfaces#116.

This also fixes a test failure introduced by the deprecation notice.

@jacobperron jacobperron changed the title Remove usage of deprecated std_msgs and std_srvs packages [ros2interface] Remove usage of deprecated std_msgs and std_srvs packages May 20, 2020
@jacobperron
Copy link
Member Author

We should also consider removing/replacing usage in other ros2cli packages.

@jacobperron jacobperron added the bug Something isn't working label May 20, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @jacobperron !

ros2interface/test/test_cli.py Outdated Show resolved Hide resolved
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 7362d35 into master May 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/rm_std_msgs_depend branch May 22, 2020 18:41
craigh92 pushed a commit to craigh92/ros2cli that referenced this pull request Jun 11, 2020
…ages (ros2#516)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Craig <CraigUkaea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants