Devcontainer support#3845
Merged
audrow merged 7 commits intoros2:rollingfrom Sep 29, 2023
cychitivav:devcontainer
Merged
Conversation
Collaborator
|
related to #3528 |
clalancette
previously requested changes
Aug 21, 2023
audrow
reviewed
Sep 14, 2023
Member
audrow
left a comment
audrow
left a comment
There was a problem hiding this comment.
This looks like a great contribution to me.
I made a few comments. Once those are addressed, this should be good to merge in.
Thanks for the PR @cychitivav!
Co-authored-by: Audrow Nash <audrow@intrinsic.ai>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
approved these changes
Sep 28, 2023
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with the final confirmation.
Collaborator
|
i want to have the final confirmation on #3845 (comment), if that works for you, i think this is good to go. |
Member
|
Thanks @cychitivav for the PR and @fujitatomoya for the iteration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the configurations to use GitHub Codespaces, which makes contributions easier as the only prerequisite is to have a GitHub account. Additionally, within this container, you can preview the HTML and everything in the cloud.