Add devcontainer.json to simplify local documentation creation and build task for VS Code#3528
Add devcontainer.json to simplify local documentation creation and build task for VS Code#3528Bi0T1N wants to merge 2 commits intoros2:rollingfrom
Conversation
information at https://containers.dev/ Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
run with Ctrl+Shift+B or select from tasks menu via Ctrl+Shift+P Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
i am not necessarily against this enhancement, probably most of developers use vscode especially documentation development. with that expected condition, it would be better to verify on local environment before creating PR with vscode. but i am not sure about the policy, so would like to hear opinion.
if we take this PR, https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.html#building-the-site-locally should be also update to how to check with vscode?
clalancette
left a comment
There was a problem hiding this comment.
After reviewing this, we have some concerns about this pull request.
- This configuration seems to install some arbitrary packages on developer machines. It will install extensions (though the user has to confirm this), and further it will install the
esboniopackage, which we don't know anything about. - In general, this seems like an individual setup, rather than a project-wide setting. Otherw users of vscode might want to use a different set of extensions. Additionally, we could have similar configurations for emacs, vim, sublime, etc etc. And we don't want to maintain all of those.
|
Because of the reasons above, I'm going to close this pull request out. Thank you for the contribution. |
It doesn't install packages on the developer machine. Everything is encapsulated in the Docker/container image and thus you can even use it with GitHub Codespaces in your webbrowser.
It's the basic setup with all tools you need to edit, create, view and finally commit your changes. If you want to have another extensions, simply add it and rebuild the container. If you still don't want to accept it as proposed in this PR, would it be okay to add another chapter within the Contributing to ROS 2 Documentation page? |
|
personally i am not inclined to take editor specific setting in the repository
same reasons apply to this. i would not recommend this. after all, i am not positive to take this approach, but open to discuss and hear more opinion. thanks, |
This adds a
devcontainer.jsonwhich is based on the providedDockerfileand at the moment it is only configured for Visual Studio Code. Thus it also adds atasks.jsonto provide a default build task.It helps to verify changes locally before committing 😄