Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose allocator interface to publishers and subscriptions #117

Closed
wants to merge 18 commits into from

Conversation

jacquelinekay
Copy link
Contributor

Not ready for full review yet, but I'm opening this PR to get feedback about the approach.

An ament repo with an alternative allocator is available here:

https://github.com/ros2/tlsf_cpp

@jacquelinekay jacquelinekay added the in progress Actively being worked on (Kanban column) label Oct 8, 2015
@wjwwood
Copy link
Member

wjwwood commented Oct 8, 2015

Looks like a file called allocator_deleter.hpp is missing, or is that what will be in the external package?

@jacquelinekay
Copy link
Contributor Author

oops, yeah, thanks for catching that

size_t queue_size
) : node_handle_(node_handle), publisher_handle_(publisher_handle),
topic_(topic), queue_size_(queue_size),
intra_process_publisher_handle_(nullptr),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in the last two lines.

@jacquelinekay
Copy link
Contributor Author

I'm in the process of breaking up what independent parts of this PR that I can.

I may do yet another overhaul of the API because I still haven't sketched out the codepath for passing allocators to incidental STL structures used by Publisher, Subscribers, etc.

@jacquelinekay
Copy link
Contributor Author

Closing this because I have a different approach that I think is better.

@jacquelinekay jacquelinekay removed the in progress Actively being worked on (Kanban column) label Oct 20, 2015
@jacquelinekay jacquelinekay deleted the rt_intra_process branch November 5, 2015 23:17
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…s2#54)

- This allows to stop the replaying of the messages by pressing ctrl-c
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants