Expose allocator interface to publishers and subscriptions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a file called |
|
oops, yeah, thanks for catching that |
jacquelinekay
force-pushed
the
rt_intra_process
branch
from
b40dc90
to
6bfa7ed
Compare
| size_t queue_size | ||
| ) : node_handle_(node_handle), publisher_handle_(publisher_handle), | ||
| topic_(topic), queue_size_(queue_size), | ||
| intra_process_publisher_handle_(nullptr), |
There was a problem hiding this comment.
Inconsistent indentation in the last two lines.
added 13 commits
October 8, 2015 17:11
Conflicts: rclcpp/include/rclcpp/any_subscription_callback.hpp rclcpp/include/rclcpp/subscription.hpp
|
I'm in the process of breaking up what independent parts of this PR that I can. I may do yet another overhaul of the API because I still haven't sketched out the codepath for passing allocators to incidental STL structures used by Publisher, Subscribers, etc. |
|
Closing this because I have a different approach that I think is better. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…s2#54) - This allows to stop the replaying of the messages by pressing ctrl-c
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for full review yet, but I'm opening this PR to get feedback about the approach.
An ament repo with an alternative allocator is available here:
https://github.com/ros2/tlsf_cpp