allow to start a node without a ParameterEvent publisher #54
Labels
enhancement
New feature or request
Comments
Merged
|
I believe this is done in #614, though I don't think any tests are making use of this at the moment. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this issue
Aug 5, 2022
* ros2GH-52 Extend db schema to include topic meta data - Two table db layout (messages and topics) - Messages table references topics table but without foreign key for improved write performance - Create_topic must be called for every topic prior to storing a message of this topic. - Sqlite_storage caches all known topics - At least for now the type information is stored as a simple string. * ros2GH-54 Make first rcl subscription prototype work * ros2GH-54 find type name from topic * ros2GH-54 Publish messages from database knowing only topic name and pass topic name by terminal * ros2GH-54 Refactoring of typesupport helpers * ros2GH-54 Use c++ typesupport * ros2GH-54 Use cpp typesupport and rclcpp::Node for publisher * ros2GH-54 Add raw subscription and use in rosbag_record * ros2GH-54 Add Rosbag2Node and Rosbag2Publisher classes and use them in Rosbag2::play * ros2GH-54 Rename Rosbag2Publisher to RawPublisher * ros2GH-54 Minor refactoring of Rosbag2Node * ros2GH-54 Extract and test waiting for topic into its own method * ros2GH-54 Fix read integration tests and linters * ros2GH-55 Refactor Rosbag2Node::create_raw_publisher() * ros2GH-54 Add subscription method to rosbag node * ros2GH-54 Keep subscription alive * ros2GH-54: Extract subscription to correct class * ros2GH-55 Change interface of raw_publisher to match subscriber * ros2GH-54 Add test for rosbag node * ros2GH-54 Unfriend rclcpp class * ros2GH-54 Make test more robust * ros2GH-54 Fix build * ros2GH-54 Minor cleanup and documentation * ros2GH-55 Minor refactoring + TODO comment * ros2GH-54 Change dynamic library folder on Windows * ros2GH-54 Fix build * ros2GH-54 Add shutdown to test * ros2GH-55 Add test helpers methods for usage in multiple tests * ros2GH-55 Add new method to read all topics and types in BaseReadInterface and use it in Rosbag2::play * ros2GH-55 Fix gcc and msvc * ros2GH-54 Rename raw to generic in publisher/subscriber * ros2GH-55 Check that topic and associated type in bag file are well defined before playing back messages * ros2GH-54 Prevent unnecessary error message loading storage * ros2GH-54 Fix memory leak * ros2GH-54 stabilize node test * ros2GH-55 Check if database exists when opening storage with READ_ONLY flag * ros2GH-54 Minor cleanup of subscriber * ros2GH-54 Wait a small amount of time to let node discover other nodes * Add logging to false case * ros2GH-54 Catch exceptions and exit cleanly * Use rmw_serialized_message_t and rcutils_char_array_t consistently * ros2GH-4 Refactoring for correctness - pass a few strings as const reference - throw error when no topics could be found * Improve error messages when loading plugins * alphabetical order * type_id -> type
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this issue
Aug 5, 2022
…s2#54) - This allows to stop the replaying of the messages by pressing ctrl-c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For unit tests it would be good to start nodes without any additional overhead as it simplifies debugging.
rclcpp/rclcpp/include/rclcpp/node_impl.hpp
Lines 60 to 61 in 5baa519
The text was updated successfully, but these errors were encountered: