Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always ensure that the ROS_DOMAIN_ID is set #102

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Sep 4, 2015

Needed to support ros2/rmw_opensplice#81

Connects to ros2/rmw_opensplice#81

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Sep 4, 2015
@wjwwood wjwwood force-pushed the opensplice_dynamic_ros_domain_id branch 2 times, most recently from c735d88 to 59729da Compare September 15, 2015 23:07
@wjwwood
Copy link
Member Author

wjwwood commented Sep 16, 2015

This is now just a minor improvement. I can squash before merging.

@dirk-thomas
Copy link
Member

+1

@wjwwood wjwwood force-pushed the opensplice_dynamic_ros_domain_id branch from 59729da to 3eb44ed Compare September 16, 2015 22:51
wjwwood added a commit that referenced this pull request Sep 17, 2015
always ensure that the ROS_DOMAIN_ID is set
@wjwwood wjwwood merged commit d8b7ce8 into master Sep 17, 2015
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Sep 17, 2015
@wjwwood wjwwood deleted the opensplice_dynamic_ros_domain_id branch September 17, 2015 21:20
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* ros2GH-101 Add converter interface

* ros2GH-102 Create format converter factory

* ros2GH-103 Write documentation for converter plugin authors

* ros2GH-16 Adjust rosbag2 message type

* ros2GH-16 Change name of converter interface to include "serialization"

- Easier to differentiate between storage format (e.g. sqlite)
  and serialization format (e.g. cdr)
- Closer to naming in ros middleware

* ros2GH-16 Improve plugin development documentation

- Also adapt to name changes

* ros2GH-16 Fix naming of SerializationFormatConverterFactory
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
mauropasse pushed a commit to mauropasse/rclcpp that referenced this pull request Feb 7, 2023
…mpty-ipc

Not throw exception -  Dequeue empty intra-process buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants