Expose composable_lifecycle_node in front-end #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
emersonknapp
approved these changes
Oct 7, 2025
Contributor
|
Pulls: #480
|
Contributor
Author
|
@ahcorde, there is a mypy typing syntax error, which I suspect to be the cause of the failing tests. EDIT: It should be fixed now |
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Contributor
|
fujitatomoya
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose
composable_lifecycle_nodes for use inload_node_componentandcomposable_node_containerfrom the front-end.Fixes #478
Is this user-facing behavior change?
Yes, users can now auto start lifecycle node components from front-ends such as
launch_xmlandlaunch_yaml.Did you use Generative AI?
No
Additional Information
There are no front-end tests yet, since there are no example/demo lifecycle component nodes (no current lifecycle talker listener component).
So there is no 'simple' case to test.
While I was making some custom debugging node I ran into #479.