Dead code line using `lstrip()` without assignment

[christophebedard]

I found a line that doesn't do anything:

launch_ros/launch_ros/launch_ros/actions/node.py

Line 399 in 3569f0d

self.__expanded_node_name.lstrip('/')

However, self.__expanded_node_name is later used in a call to prefix_namespace(():

launch_ros/launch_ros/launch_ros/actions/node.py

Lines 423 to 424 in 3569f0d

	self.__final_node_name = prefix_namespace(
	self.__expanded_node_namespace, self.__expanded_node_name)

And, according to prefix_namespace(), there's definitely a difference between self.__expanded_node_name with and without a leading / :

launch_ros/launch_ros/launch_ros/utilities/namespace_utils.py

Lines 53 to 60 in 3569f0d

	combined_ns = prefix_namespace('my_ns', 'original_ns')
	assert combined_ns == 'my_ns/original_ns'
	combined_ns = prefix_namespace('/my_ns', 'original_ns')
	assert combined_ns == '/my_ns/original_ns'
	combined_ns = prefix_namespace('my_ns', '/original_ns')
	assert combined_ns == '/original_ns'

I guess at this point it works fine, in which case the line could just be removed.

[k3rnel-pan1c-a]

Hi, I'm a first time contributor, is it okay if I start working on this?

[christophebedard]

Of course! Let us know if you have any questions.

[kscottz]

@k3rnel-pan1c-a how is it going? Need some help?