Migrate content from std_msgs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
hidmic
reviewed
May 18, 2020
msg/Bool.msg
Outdated
| @@ -0,0 +1,5 @@ | |||
| # This is an example message of using a primative datatype, bool. | |||
| # If you want to test with this that's fine, but if you are deploying | |||
| # it into a system you should create a semantically meaningful custom message. | |||
There was a problem hiding this comment.
@tfoote consider
Suggested change
| # it into a system you should create a semantically meaningful custom message. | |
| # it into a system you should create a semantically meaningful message type. |
same elsewhere.
msg/Bool.msg
Outdated
| # This is an example message of using a primative datatype, bool. | ||
| # If you want to test with this that's fine, but if you are deploying | ||
| # it into a system you should create a semantically meaningful custom message. | ||
| # If you want to embed it in another message use the primative not this message. |
There was a problem hiding this comment.
@tfoote consider:
Suggested change
| # If you want to embed it in another message use the primative not this message. | |
| # If you want to embed it in another message, use the primitive data type instead. |
same elsewhere.
msg/Bool.msg
Outdated
| @@ -0,0 +1,5 @@ | |||
| # This is an example message of using a primative datatype, bool. | |||
There was a problem hiding this comment.
@tfoote consider
Suggested change
| # This is an example message of using a primative datatype, bool. | |
| # This is an example message of using a primitive datatype, bool. |
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
|
Good suggestions, updated. |
jacobperron
approved these changes
May 19, 2020
hidmic
approved these changes
May 21, 2020
| @@ -0,0 +1,30 @@ | |||
| # This is an example of using complex datatypes. | |||
| # It is not recommended to use directly. | |||
| # To use a similar datastruct please define a custom message with appropriate semantic meaning. | |||
There was a problem hiding this comment.
@tfoote datastruct -- In other places we talk about data types in a similar, almost equivalent way. Consider standardizing the terminology.
There was a problem hiding this comment.
I specifically chose datastruct here to refer to the structure as opposed to the type as the guidance is to make a new type (indirectly by the new message).
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/soss-a-whole-new-approach-to-your-ros-1-ros-2-bridge/17040/18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This if following up ros2/common_interfaces#89