Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate content from std_msgs #11

Merged
merged 8 commits into from
May 21, 2020
Merged

Migrate content from std_msgs #11

merged 8 commits into from
May 21, 2020

Conversation

tfoote
Copy link
Contributor

@tfoote tfoote commented May 18, 2020

This if following up ros2/common_interfaces#89

tfoote added 6 commits May 5, 2020 18:17
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
msg/Bool.msg Outdated
@@ -0,0 +1,5 @@
# This is an example message of using a primative datatype, bool.
# If you want to test with this that's fine, but if you are deploying
# it into a system you should create a semantically meaningful custom message.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote consider

Suggested change
# it into a system you should create a semantically meaningful custom message.
# it into a system you should create a semantically meaningful message type.

same elsewhere.

msg/Bool.msg Outdated
# This is an example message of using a primative datatype, bool.
# If you want to test with this that's fine, but if you are deploying
# it into a system you should create a semantically meaningful custom message.
# If you want to embed it in another message use the primative not this message.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote consider:

Suggested change
# If you want to embed it in another message use the primative not this message.
# If you want to embed it in another message, use the primitive data type instead.

same elsewhere.

msg/Bool.msg Outdated
@@ -0,0 +1,5 @@
# This is an example message of using a primative datatype, bool.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote consider

Suggested change
# This is an example message of using a primative datatype, bool.
# This is an example message of using a primitive datatype, bool.

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote
Copy link
Contributor Author

tfoote commented May 18, 2020

Good suggestions, updated.

@tfoote tfoote requested a review from hidmic May 18, 2020 23:28
@tfoote tfoote self-assigned this May 18, 2020
@@ -0,0 +1,30 @@
# This is an example of using complex datatypes.
# It is not recommended to use directly.
# To use a similar datastruct please define a custom message with appropriate semantic meaning.
Copy link

@hidmic hidmic May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote datastruct -- In other places we talk about data types in a similar, almost equivalent way. Consider standardizing the terminology.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically chose datastruct here to refer to the structure as opposed to the type as the guidance is to make a new type (indirectly by the new message).

@tfoote tfoote merged commit 249222a into master May 21, 2020
@tfoote tfoote deleted the migrate_std_msgs branch May 21, 2020 00:18
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/soss-a-whole-new-approach-to-your-ros-1-ros-2-bridge/17040/18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants