Skip to content

fix: blocklist duplicate typesupport extern declarations #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esteve merged 1 commit into from
Jan 14, 2026
Merged

fix: blocklist duplicate typesupport extern declarations #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclrs/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fn get_env_var_or_abort(env_var: &'static str) -> String {
fn main() {
println!(
"cargo:rustc-check-cfg=cfg(ros_distro, values(\"{}\"))",
vec!["humble", "jazzy", "kilted", "rolling"].join("\", \"")
["humble", "jazzy", "kilted", "rolling"].join("\", \"")
);
let ros_distro = if let Ok(value) = env::var(ROS_DISTRO) {
value
Expand Down
8 changes: 8 additions & 0 deletions rclrs/generate_bindings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ def main():
bindgen_command.append('rcutils_.*')
bindgen_command.append('--allowlist-var')
bindgen_command.append('rosidl_.*')
# Blocklist typesupport functions that are already declared in vendored message crates
# (rosidl_generator_rs generates these with *const c_void return type)
bindgen_command.append('--blocklist-function')
bindgen_command.append('rosidl_typesupport_.*__get_message_type_support_handle__.*')
bindgen_command.append('--blocklist-function')
bindgen_command.append('rosidl_typesupport_.*__get_service_type_support_handle__.*')
bindgen_command.append('--blocklist-function')
bindgen_command.append('rosidl_typesupport_.*__get_action_type_support_handle__.*')
bindgen_command.append('--no-layout-tests')
bindgen_command.append('--default-enum-style')
bindgen_command.append('rust')
Expand Down
26 changes: 1 addition & 25 deletions rclrs/src/rcl_bindings_generated_humble.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* automatically generated by rust-bindgen 0.72.1 */
/* automatically generated by rust-bindgen 0.72.0 */

pub type rcutils_ret_t = ::std::os::raw::c_int;
#[repr(C)]
Expand Down Expand Up @@ -3404,10 +3404,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatus {
Expand All @@ -3421,19 +3417,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatusArray {
pub status_list: action_msgs__msg__GoalStatus__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__srv__CancelGoal_Request {
Expand All @@ -3445,18 +3433,6 @@ pub struct action_msgs__srv__CancelGoal_Response {
pub return_code: i8,
pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
) -> *const rosidl_service_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct rosidl_action_type_support_t {
Expand Down
49 changes: 4 additions & 45 deletions rclrs/src/rcl_bindings_generated_jazzy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* automatically generated by rust-bindgen 0.72.1 */
/* automatically generated by rust-bindgen 0.72.0 */

pub type rcutils_ret_t = ::std::os::raw::c_int;
#[repr(C)]
Expand Down Expand Up @@ -526,6 +526,9 @@ unsafe extern "C" {
unsafe extern "C" {
pub fn rcutils_steady_time_now(now: *mut rcutils_time_point_value_t) -> rcutils_ret_t;
}
unsafe extern "C" {
pub fn rcutils_raw_steady_time_now(now: *mut rcutils_time_point_value_t) -> rcutils_ret_t;
}
unsafe extern "C" {
pub fn rcutils_time_point_value_as_nanoseconds_string(
time_point: *const rcutils_time_point_value_t,
Expand Down Expand Up @@ -2776,22 +2779,6 @@ pub struct rosidl_action_type_support_t {
pub get_type_description_func: rosidl_action_get_type_description_function,
pub get_type_description_sources_func: rosidl_action_get_type_description_sources_function,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Request(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Response(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Event(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_service_type_support_handle__type_description_interfaces__srv__GetTypeDescription(
) -> *const rosidl_service_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__create_service_event_message__type_description_interfaces__srv__GetTypeDescription(
info: *const rosidl_service_introspection_info_t,
Expand Down Expand Up @@ -8530,10 +8517,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatus {
Expand All @@ -8547,19 +8530,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatusArray {
pub status_list: action_msgs__msg__GoalStatus__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__srv__CancelGoal_Request {
Expand All @@ -8571,22 +8546,6 @@ pub struct action_msgs__srv__CancelGoal_Response {
pub return_code: i8,
pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Event(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
) -> *const rosidl_service_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__create_service_event_message__action_msgs__srv__CancelGoal(
info: *const rosidl_service_introspection_info_t,
Expand Down
49 changes: 4 additions & 45 deletions rclrs/src/rcl_bindings_generated_kilted.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* automatically generated by rust-bindgen 0.72.1 */
/* automatically generated by rust-bindgen 0.72.0 */

pub type rcutils_ret_t = ::std::os::raw::c_int;
#[repr(C)]
Expand Down Expand Up @@ -526,6 +526,9 @@ unsafe extern "C" {
unsafe extern "C" {
pub fn rcutils_steady_time_now(now: *mut rcutils_time_point_value_t) -> rcutils_ret_t;
}
unsafe extern "C" {
pub fn rcutils_raw_steady_time_now(now: *mut rcutils_time_point_value_t) -> rcutils_ret_t;
}
unsafe extern "C" {
pub fn rcutils_time_point_value_as_nanoseconds_string(
time_point: *const rcutils_time_point_value_t,
Expand Down Expand Up @@ -2780,22 +2783,6 @@ pub struct rosidl_action_type_support_t {
pub get_type_description_func: rosidl_action_get_type_description_function,
pub get_type_description_sources_func: rosidl_action_get_type_description_sources_function,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Request(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Response(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__type_description_interfaces__srv__GetTypeDescription_Event(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_service_type_support_handle__type_description_interfaces__srv__GetTypeDescription(
) -> *const rosidl_service_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__create_service_event_message__type_description_interfaces__srv__GetTypeDescription(
info: *const rosidl_service_introspection_info_t,
Expand Down Expand Up @@ -8392,10 +8379,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatus {
Expand All @@ -8409,19 +8392,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
pub size: usize,
pub capacity: usize,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__msg__GoalStatusArray {
pub status_list: action_msgs__msg__GoalStatus__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
) -> *const rosidl_message_type_support_t;
}
#[repr(C)]
#[derive(Debug)]
pub struct action_msgs__srv__CancelGoal_Request {
Expand All @@ -8433,22 +8408,6 @@ pub struct action_msgs__srv__CancelGoal_Response {
pub return_code: i8,
pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Event(
) -> *const rosidl_message_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
) -> *const rosidl_service_type_support_t;
}
unsafe extern "C" {
pub fn rosidl_typesupport_c__create_service_event_message__action_msgs__srv__CancelGoal(
info: *const rosidl_service_introspection_info_t,
Expand Down
Loading