Skip to content

rosdep: drop legacy Python 2 keys - Stage 4 (80%)#51719

Draft
mjcarroll wants to merge 1 commit into
ros:drop-py2-stage-3from
mjcarroll:drop-py2-stage-4
Draft

rosdep: drop legacy Python 2 keys - Stage 4 (80%)#51719
mjcarroll wants to merge 1 commit into
ros:drop-py2-stage-3from
mjcarroll:drop-py2-stage-4

Conversation

@mjcarroll
Copy link
Copy Markdown
Member

Part of Python 2 drop. Links to #51715

@mjcarroll mjcarroll requested a review from a team as a code owner May 29, 2026 15:19
@github-actions github-actions Bot added the rosdep Issue/PR is for a rosdep key label May 29, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'
  • ✅ Platforms for new rosdep rules are valid
  • ❌ There are problems with explicitly provided installers:
    • One or more explicitly provided installer is not supported by rosdep
  • ❌ There are problems with rosdep key suitability:
    • Rules exclusively for pip may not be added when there are system packages available
  • 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Comment thread rosdep/python.yaml Outdated
Comment thread rosdep/python.yaml Outdated
Comment thread rosdep/python.yaml Outdated
Comment thread rosdep/python.yaml Outdated
@mjcarroll mjcarroll marked this pull request as draft May 29, 2026 15:23
@mjcarroll mjcarroll changed the base branch from master to drop-py2-stage-3 May 29, 2026 15:26
Drop the fourth batch (102 keys) of legacy Python 2 keys from the database.

Assisted-by: Gemini CLI:2.0-Pro [list_dir, view_file, run_command]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant