Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding qt4-linguist-tools rosdep key #27390

Merged
merged 4 commits into from
Dec 11, 2020
Merged

adding qt4-linguist-tools rosdep key #27390

merged 4 commits into from
Dec 11, 2020

Conversation

zflat
Copy link
Contributor

@zflat zflat commented Nov 19, 2020 •
edited by nuclearsandwich
Loading

adding qt4-linguist-tools
2e12a87 
provides binaries lrealease and lupdate
@zflat zflat changed the title adding qt4-linguist-tools adding qt4-linguist-tools rosdep key Nov 19, 2020
@tfoote tfoote added the rosdep Issue/PR is for a rosdep key label Nov 20, 2020
@tfoote
Copy link
Member

tfoote commented Nov 20, 2020

This is in draft status. Is there more you plan to add?

@zflat zflat marked this pull request as ready for review November 30, 2020 15:45
@zflat zflat requested a review from a team as a code owner November 30, 2020 15:45
@zflat
Copy link
Contributor Author

zflat commented Nov 30, 2020

This is in draft status. Is there more you plan to add?

I just left it in draft state while checks were running and did not come back to change it. Thanks for checking!

@tfoote tfoote requested a review from a team December 1, 2020 18:34
clalancette
clalancette previously requested changes Dec 1, 2020
View reviewed changes
rosdep/base.yaml Outdated Show resolved Hide resolved
rosdep/base.yaml Outdated Show resolved Hide resolved
William Wedler added 3 commits December 10, 2020 16:48
Correcting OS specific packages
e23ef9e 
- Ubuntu does not have support as of Focal
- Fedora requires qt-devel
wrap in [] brackets
cee5570
sorted
4b2991d
@zflat
Copy link
Contributor Author

zflat commented Dec 11, 2020

@clalancette I agree with your suggestions and applied them. Thanks for the feedback!

@nuclearsandwich nuclearsandwich merged commit 1f4342f into ros:master Dec 11, 2020
@cottsay cottsay mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@tfoote tfoote tfoote approved these changes

@clalancette clalancette clalancette left review comments

Assignees
No one assigned
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zflat @tfoote @clalancette @nuclearsandwich