Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apparmor #21906

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Add apparmor #21906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6625d6
Add AppArmor
ruffsl Aug 2, 2019
61989c3
Set fedora to null for apparmor
ruffsl Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rosdep/base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ apache2-mpm-prefork:
wheezy: [apache2-mpm-prefork]
gentoo: ['www-servers/apache[apache2_mpms_prefork]']
ubuntu: [apache2-mpm-prefork]
apparmor:
debian: [apparmor]
fedora: null
ubuntu: [apparmor]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed above, this won't realistically ever be available for Fedora. I'm thinking we should put an explicit fedora: null here, to indicate that it can't be available for Fedora (rather than just not being done, or something that could be done later).

Copy link
Contributor Author

@ruffsl ruffsl Oct 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never realized rosdistro was using null to explicitly state unavailability, as it seems the null set is arbitrarily large. If this is common practice, then I can update the PR accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a relatively new practice, and to be honest, the tools don't support it all that well (rosdep just throws a stacktrace if you try to install a null key). But I think it should be straightforward enough to enhance the tools to make it nicer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've added 61989c3

apr:
alpine: [apr, apr-util]
arch: [apr, apr-util]
Expand Down