[ROS-O] do away with boost::bind #86
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literal boost _1 is deprecated for a long time due to std::bind. lambas are preferred.
ahcorde
approved these changes
Aug 21, 2024
Contributor
|
Retargeted PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
literal boost _1 is deprecated for a long time due to std::bind. lambas are preferred.
This line started failing with a recently proposed patch in ROS-O.
Note: Using the lambda requires melodic+, so you should create a new melodic/noetic branch for this.
(I'm also happy to use the alternative
boost::placeholders::prefix if you prefer that).